-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename post_only
to secure_only
and allow for future enhancements to use bearer tokens
#21180
Conversation
Update relevant FAQ as well. |
@sgiehl ready for review, relevant UI test screenshots updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. Otherwise this looks good to merge
Will update the UI screenshots again to account for the changed table header and then it'll be good to merge I guess. Have updated the FAQ as well — https://matomo.org/faq/general/faq_114/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍
Description:
As per the title, renaming the config and the db field to future proof the feature.
Review